Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo fixes in samples and JandexUtil + EmbeddingStoreJsonRPCService from core #1179

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Typo fixes in samples and JandexUtil + EmbeddingStoreJsonRPCService from core #1179

merged 2 commits into from
Dec 23, 2024

Conversation

rsvoboda
Copy link
Contributor

  • Typo fixes in JandexUtil and EmbeddingStoreJsonRPCService
  • Typo fixes in samples

for login vs. log in I followed explanation from https://www.reddit.com/r/webdev/comments/aml4hb/login_vs_log_in_are_we_using_these_wrong/

@rsvoboda rsvoboda requested a review from a team as a code owner December 23, 2024 13:21
geoand
geoand approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rsvoboda!

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Dec 23, 2024

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit c235cf1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit c4d79bf into quarkiverse:main Dec 23, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@jmartisk jmartisk jmartisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rsvoboda @jmartisk @geoand